sopel: don't use bot.search_url_callbacks internally #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to emit warnings, the method Sopel.search_url_callbacks must not be used internally or through a built-in plugin. As a result, and until removal in Sopel 9, both coretasks and url are going to access bot._url_callbacks directly. Also, the method `bot.call` is now deprecated and will be removed in Sopel 9.0, following a short deprecation cycle. This method should have been deprecated since Sopel 8 but was kept in order to keep the old URL callbacks system working. When it is gone, this method won't be needed anymore.
dgw
reviewed
Oct 19, 2024
There was a problem hiding this comment.
At a glance from my phone, this looks sane. TIL GitHub only shows the "Viewed" checkbox on files in landscape orientation. :/
Thank you for your service,
register_url_callback, but I can't wait to remove you and your sister methods!
I was pretty excited about that too… #2436 is biding its time since early last year (but obviously will need a rebase to move out of draft status; I knew the risks going in!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
coretasksandurlusedbot.search_url_callbacks, that was deprecated some time ago and wants to emit warning in Sopel 8.1. Because it was used, we didn't bump Sopel's version to 8.1.0.dev0 yet, and that was annoying.Therefore, I replaced that by a direct access to the private attribute
_url_callbacks, and then bumped to Sopel 8.1.0.dev0. And by the way, we should be able to removebot.callin Sopel 9.Thank you for your service,
register_url_callback, but I can't wait to remove you and your sister methods!Checklist
make qa(runsmake lintandmake test)